feat(http): Switch to memory cache provider #33901
Conversation
…cache-provider-switch
…-cache-provider-switch
…-cache-provider-switch
| @@ -13,7 +13,6 @@ async function matchingBranches( | |||
| ): Promise<string[]> { | |||
| const { body: branches } = await githubApi.getJson( | |||
| `/repos/${repo}/git/matching-refs/heads/${branchName}`, | |||
| { memCache: false }, | |||
There was a problem hiding this comment.
Can you explain why the memCache=false parts are no longer needed?
There was a problem hiding this comment.
memCache=false is the equivalent of the absent cacheProvider option
There was a problem hiding this comment.
And yes, no memory cache is the default now
There was a problem hiding this comment.
How can we be confident that we haven't missed anything?
There was a problem hiding this comment.
Generally speaking, we can't. What we can is analyze HTTP stats and watch for repeating GET requests (sometimes, though, it's intended).
There was a problem hiding this comment.
Can you summarize all the cases where http memcache is still being explicitly enabled in this PR (seems to be within platform code) and we evaluate whether we're better to add platform-level caching (e.g. of PR lists) instead of relying on http-level? Maybe you can do this through inline PR comments
Changes
Make caching of GET/HEAD HTTP requests disabled by default.
When it's needed, the
memCacheProvideris be used.Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: